[Win32] Fix tree tooltips for reordered columns#3366
Open
HeikoKlare wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect Win32 Tree in-place tooltip text when columns are reordered, by mapping the hovered visual column index to the underlying creation column index before retrieving the cell text.
Changes:
- Use
getColumnOrder()to translate the hit-tested column position into the correct model/creation index for tooltip text lookup. - Update tooltip text retrieval to use the mapped index for non-first columns.
When reordering columns of a tree control, wrong tooltips are shown when hovering over a cell that is too small to show the full content. Instead of the content of the actual cell at that place, the one of the cell that was originally placed at that position (without column reordering) is shown. This change corrects the index used for retrieving the tooltip content by considering the column order.
09515ab to
4f1a302
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reordering columns of a tree control, wrong tooltips are shown when hovering over a cell that is too small to show the full content. Instead of the content of the actual cell at that place, the one of the cell that was originally placed at that position (without column reordering) is shown.
This change corrects the index used for retrieving the tooltip content by considering the column order.
Found when working on:
How to test
For example with the following snippet:
When reordering the two columns, you see the following results:
Without the change:

With the change:
